Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary comment in Specify Hyperparameters Manually tutorial page #5258

Merged
merged 1 commit into from Feb 21, 2024

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Feb 19, 2024

Motivation

The tutorial page does not use callback anymore. We can remove the comment line mentioning callback.

Description of the changes

As is the title.

@nzw0301 nzw0301 added the document Documentation related. label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bcda7a) 89.23% compared to head (ea3a7c6) 89.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5258      +/-   ##
==========================================
- Coverage   89.23%   89.22%   -0.01%     
==========================================
  Files         206      206              
  Lines       12944    12944              
==========================================
- Hits        11550    11549       -1     
- Misses       1394     1395       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nabenabe0928
Copy link
Collaborator

@y0z Could you review this PR?

Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, LGTM!

@nabenabe0928 nabenabe0928 removed their assignment Feb 20, 2024
Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z removed their assignment Feb 20, 2024
@nabenabe0928 nabenabe0928 merged commit cbf62c3 into optuna:master Feb 21, 2024
21 checks passed
@nzw0301 nzw0301 deleted the revise-specify-params-tutorial branch February 21, 2024 03:32
@nzw0301 nzw0301 added this to the v3.6.0 milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants