Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify indent size, two in toml file #5271

Merged
merged 1 commit into from Feb 26, 2024

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Feb 23, 2024

Motivation

I was a bit uncomfortable using different indent sizes in the toml file when I checked the file. Even there is no style guide in toml (toml-lang/toml#608).

Description of the changes

Replace four space indent with two by following https://packaging.python.org/en/latest/guides/writing-pyproject-toml/.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.59%. Comparing base (855692a) to head (0791891).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5271      +/-   ##
==========================================
+ Coverage   89.57%   89.59%   +0.01%     
==========================================
  Files         209      209              
  Lines       13097    13097              
==========================================
+ Hits        11732    11734       +2     
+ Misses       1365     1363       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@contramundum53 contramundum53 added the CI Continuous integration. label Feb 26, 2024
@contramundum53 contramundum53 added this to the v3.6.0 milestone Feb 26, 2024
@contramundum53 contramundum53 merged commit d11cb5d into optuna:master Feb 26, 2024
29 checks passed
@nzw0301 nzw0301 deleted the unify-toml-indent-size branch February 26, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants