Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up for split integrations #5277

Merged
merged 10 commits into from Mar 4, 2024

Conversation

gen740
Copy link
Collaborator

@gen740 gen740 commented Feb 26, 2024

Motivation

Task #4484 has been completed. However, there are some pending items in the backlog.

The file test_integration.py is ineffective. Consequently, the integration CI is meaningless.

Description of the changes

  • Remove integration_test.yml
  • Remove integration-test from mac-tests.yml and windows-tests.yml
  • Refactor test_samplers.py.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.56%. Comparing base (e23623c) to head (1e91a62).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5277      +/-   ##
==========================================
- Coverage   89.59%   89.56%   -0.04%     
==========================================
  Files         209      209              
  Lines       13103    13103              
==========================================
- Hits        11740    11736       -4     
- Misses       1363     1367       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y0z
Copy link
Member

y0z commented Feb 27, 2024

@eukaryo Could you review this PR?

@contramundum53 contramundum53 added the CI Continuous integration. label Feb 27, 2024
Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@y0z y0z removed their assignment Mar 1, 2024
@eukaryo
Copy link
Collaborator

eukaryo commented Mar 4, 2024

LGTM.

@eukaryo eukaryo added this to the v3.6.0 milestone Mar 4, 2024
@eukaryo eukaryo merged commit d132cd9 into optuna:master Mar 4, 2024
24 checks passed
@eukaryo eukaryo removed their assignment Mar 4, 2024
@gen740 gen740 deleted the follow_up_for_split_integrations branch March 4, 2024 05:01
@gen740 gen740 restored the follow_up_for_split_integrations branch March 4, 2024 17:18
@gen740 gen740 deleted the follow_up_for_split_integrations branch March 4, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants