-
-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support constrained optimization in best_trial
#5426
Merged
HideakiImamura
merged 8 commits into
optuna:master
from
not522:best-trial-constrained-optimization
May 21, 2024
+125
−14
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cbdf017
Support constrained optimization in best_trial
not522 a9e4180
Add comment for constrained optimization in best_trial
not522 0069ab4
Update feasibility checking logic
not522 796f8f9
Update feasibility checking logic
not522 4a170d9
Check whether constrained optimization
not522 d31447c
Organize implementations of constrained optimization
not522 8821a7f
Merge branch 'master' into best-trial-constrained-optimization
not522 997ebe8
Add from __future__ import annotations
not522 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
from __future__ import annotations | ||
|
||
from collections.abc import Sequence | ||
|
||
from optuna.trial import FrozenTrial | ||
|
||
|
||
_CONSTRAINTS_KEY = "constraints" | ||
|
||
|
||
def _get_feasible_trials(trials: Sequence[FrozenTrial]) -> list[FrozenTrial]: | ||
"""Return feasible trials from given trials. | ||
|
||
This function assumes that the trials were created in constrained optimization. | ||
Therefore, if there is no violation value in the trial, it is considered infeasible. | ||
|
||
|
||
Returns: | ||
A list of feasible trials. | ||
""" | ||
|
||
feasible_trials = [] | ||
for trial in trials: | ||
constraints = trial.system_attrs.get(_CONSTRAINTS_KEY) | ||
if constraints is not None and all(x <= 0.0 for x in constraints): | ||
feasible_trials.append(trial) | ||
return feasible_trials |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
from optuna.study._constrained_optimization import _CONSTRAINTS_KEY | ||
from optuna.study._constrained_optimization import _get_feasible_trials | ||
from optuna.trial import create_trial | ||
|
||
|
||
def test_get_feasible_trials() -> None: | ||
trials = [] | ||
trials.append(create_trial(value=0.0, system_attrs={_CONSTRAINTS_KEY: [0.0]})) | ||
trials.append(create_trial(value=0.0, system_attrs={_CONSTRAINTS_KEY: [1.0]})) | ||
trials.append(create_trial(value=0.0)) | ||
feasible_trials = _get_feasible_trials(trials) | ||
assert len(feasible_trials) == 1 | ||
assert feasible_trials[0] == trials[0] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use cache here or would it be buggy because some trials might finish between the last query and this query of
self.get_trials
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my understanding, the cache in
_get_trials
is taken at the beginning of the trial, so it is not appropriate to use that cache inbest_trial
. It can be a strange value sincebest_trial
is expected to be called after the trial.