Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve make clean in docs #5487

Merged

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Jun 7, 2024

Motivation

  1. if source/sg_execution_times.rst does not exist, make clean fails.
  2. journal.log is not removed by the current make clean but make html fails if it exists.

Description of the changes

  1. Add -f to exec all rm commands in make clean.
  2. Remove *.log under tutorial directory like sqlite's database file removal.

@nzw0301 nzw0301 changed the title Add -f flag to exec all rm commands Improve make clean in docs Jun 8, 2024
@nabenabe0928
Copy link
Collaborator

nabenabe0928 commented Jun 10, 2024

@eukaryo @HideakiImamura Could you review this PR?

Copy link
Collaborator

@eukaryo eukaryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eukaryo eukaryo removed their assignment Jun 13, 2024
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit 3ef184e into optuna:master Jun 17, 2024
14 checks passed
@HideakiImamura HideakiImamura added this to the v4.0.0 milestone Jun 17, 2024
@HideakiImamura HideakiImamura added the document Documentation related. label Jun 17, 2024
@nzw0301 nzw0301 deleted the make-clean-even-without-target-file branch June 17, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants