Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include MKR token edge case in _getBestAPR in APROracle.sol #270

Closed
deepcrazy opened this issue Nov 27, 2021 · 0 comments · Fixed by #271
Closed

Include MKR token edge case in _getBestAPR in APROracle.sol #270

deepcrazy opened this issue Nov 27, 2021 · 0 comments · Fixed by #271

Comments

@deepcrazy
Copy link
Contributor

  • _getBestAPR is handling the edge for WETH token as of now. However, if using getTokenConfigBySymbol(symbol) of Compound, then MKR token's edge case can be added as MKR contract returns MKR's symbol's hash and not "MKR" as string.
  • This has to be explored bit more as well as if MKR is possible scenario or not.
  • Also, Maybe we can use getTokenConfigByUnderlying(token) with an exception for MKR. However, this function also returns error right now for MKR token address and therefore needs more exploration.
@dhruvinparikh dhruvinparikh linked a pull request Nov 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants