Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests For Configurable Frequency #33

Merged
merged 4 commits into from
Oct 20, 2019
Merged

Add Tests For Configurable Frequency #33

merged 4 commits into from
Oct 20, 2019

Conversation

EmilyYLMa
Copy link
Member

  • Added tests for impedance calculation at 50Hz
  • Tests are based on results from Cyme

@coveralls
Copy link

coveralls commented Oct 18, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 173

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.5%
Totals Coverage Status
Change from base Build 160: 0.0%
Covered Lines: 126
Relevant Lines: 144
💛 - Coveralls

AnjoMan
AnjoMan requested changes Oct 19, 2019
View reviewed changes
Copy link
Member

@AnjoMan AnjoMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Should just change the function signiatures

tests/test_carsons.py Outdated Show resolved Hide resolved
tests/test_carsons.py Outdated Show resolved Hide resolved
@AnjoMan AnjoMan added the enhancement New feature or request label Oct 19, 2019
@AnjoMan
Copy link
Member

AnjoMan commented Oct 19, 2019

addresses #26

@AnjoMan AnjoMan merged commit e7a9481 into configurable-frequency Oct 20, 2019
@etimberg etimberg deleted the test_configurable_frequency branch October 27, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnjoMan AnjoMan AnjoMan approved these changes

@etimberg etimberg etimberg approved these changes

Assignees

@AnjoMan AnjoMan

@etimberg etimberg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EmilyYLMa @coveralls @AnjoMan @etimberg