Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Stay Logged In" checkboxes #10

Closed
stuartpb opened this issue Mar 23, 2015 · 8 comments
Closed

"Stay Logged In" checkboxes #10

stuartpb opened this issue Mar 23, 2015 · 8 comments

Comments

@stuartpb
Copy link
Member

We should track these: whether they're present, what the time duration is, if that's disclosed, if it's configurable, what the default is...

@stuartpb
Copy link
Member Author

Dynadot makes login duration a property of the account (options are 1, 4, and 10 hours).

@stuartpb
Copy link
Member Author

I think it would be better to have a new object on "sessions" that tracks this stuff, with maybe something like... I don't know, a way to enumerate types of login sessions are allowed (documenting whether it's freeform, per-device, configurable at login/user account, API session tokens etc)

@stuartpb
Copy link
Member Author

login.persist.checkbox is still cool, though, although it should maybe be changed to...

login.persist.on = index of session profile
login.persist.off = index of session profile
login.persist.default = index of session profile
login.persist.select = array of session profiles offered in a select dropdown at login

Alternately, maybe login.persist.default should be "on", "off", or the (one-based) index into the "select" array.

And then I guess session profiles should have labels corresponding to how they're described in the API?

@stuartpb stuartpb added this to the future milestone Jun 9, 2015
@stuartpb
Copy link
Member Author

Actually, I'd like something like login.persist.checkbox.id, even if this other stuff gets added. Also, login.persist.select.options should be the form of the array, and it could be alongside login.persist.select.id (or login.persist.select.xpath in a pathological case).

@stuartpb
Copy link
Member Author

Sounds like this should split off two new issues:

  • An issue laying out a new precedent for tracking UI elements (with id and/or xpath or selector fields)
  • An issue for tracking higher-level session persistence properties

@stuartpb
Copy link
Member Author

So there'd be

  • login.persist.checkbox, which has element fields describing the checkbox input element, as well as session-state-description-objects at login.persist.checkbox.on and login.persist.checkbox.off
  • login.persist.radio, which has element objects at login.persist.radio.off and login.persist.radio.on which each describe an element and have fields for session description (index of profile?)
  • login.persist.select, which would have... I don't know, I don't remember how select is structured off the top of my head.

@stuartpb
Copy link
Member Author

Post-#163, this is present as login.form.persist.checkbox, and everything like id will live as a sibling to that. If persistence is presented as some other kind of form element, it'll be introduced as an alternative to persist.checkbox.

And if session persistence is some not-form-based thing like what Dynadot does, then hey, it'll be somewhere outside of login.form, neat how that works out.

@stuartpb
Copy link
Member Author

I think this can be closed now. #126 was the issue opened up for tracking elements, and #133 goes into the nitty-gritty about tracking session stuff more closely (which most likely won't happen for a while).

I think, for now, I'm fine leaving login.form.persist.checkbox the extent of login-persistence profiling, putting anything that isn't a checkbox into notes until patterns emerge, and letting future developments in the persistence space get sussed out as part of discussions like #133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant