-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconciling password.reset.flow.submit and password.change #38
Comments
There's also the matter of |
This is being addressed, somewhat, by |
This is now (post-#127) part of |
I've tweaked the issue to focus on pursuing that aspect of this, how to make I thought about having This is also less awkward of a construction now that there's no |
This is a really sensible change, honestly - the only part that sticks out a bit for me is a kind of dumb one: making it so the two can easily be expressed non-redundantly, as expressed at #120 (comment). Really, I'm leaning to the side of just "eh, it's not worth getting worked up over" and moving forward with this proposal: some kind of unifying change can be introduced later, and there's no reason to make the fear-of-maybe-not-being-as-perfect-as-possible be the enemy of the good here. |
As #4 describes, there should be a field describing where you go after a password reset form is submitted (which is independent of
password.reset.token.login
).Maybe
password.reset.submit
, which could have a 'redirect' (with 'yes' or the status code used for redirection, or 'no' if it actually doesn't redirect on submission), as well as a 'location' (the URL you are redirected to). And/or something that describes if you're redirected to the login page, and if that login form has some fields pre-filled.The text was updated successfully, but these errors were encountered: