Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciling password.reset.flow.submit and password.change #38

Closed
stuartpb opened this issue Jun 16, 2015 · 6 comments
Closed

Reconciling password.reset.flow.submit and password.change #38

stuartpb opened this issue Jun 16, 2015 · 6 comments

Comments

@stuartpb
Copy link
Member

As #4 describes, there should be a field describing where you go after a password reset form is submitted (which is independent of password.reset.token.login).

Maybe password.reset.submit , which could have a 'redirect' (with 'yes' or the status code used for redirection, or 'no' if it actually doesn't redirect on submission), as well as a 'location' (the URL you are redirected to). And/or something that describes if you're redirected to the login page, and if that login form has some fields pre-filled.

@stuartpb stuartpb added this to the future milestone Jun 16, 2015
@stuartpb
Copy link
Member Author

There's also the matter of password.change.sessions.invalidate, which is similar. (Should it be documented where you go after changing a password? I feel this isn't that important and it's usually the user dashboard.)

@stuartpb
Copy link
Member Author

stuartpb commented Mar 9, 2016

This is being addressed, somewhat, by password.reset.steps (#70). URLs still aren't recorded (except when it's the ordinary login page).

@stuartpb
Copy link
Member Author

stuartpb commented Nov 5, 2016

This is now (post-#127) part of password.reset.flow.submit.destination. Though not everything mentioned here is currently addressed (ie. which login fields are pre-filled), there's room for all of it as sibling/child fields.

@stuartpb stuartpb changed the title What happens after resetting a password? What happens after changing a password? Nov 5, 2016
@stuartpb
Copy link
Member Author

stuartpb commented Nov 5, 2016

I've tweaked the issue to focus on pursuing that aspect of this, how to make password.change more resemble password.reset.flow.submit (and maybe vice versa).

I thought about having password.reset.flow.submit look more like password.change (ie. calling it password.reset.flow.change and moving password.reset.usability onto it), but I decided against it, under the thinking that it needs to be clear that the parts of that like session and destination and all are triggered when the password change is submitted: however, that could maybe be addressed by making it password.reset.flow.change.submit (and moving usability to password.reset.flow.change), which would then complement password.change.submit neatly.

This is also less awkward of a construction now that there's no expiration(.trigger) to match with the field name.

@stuartpb stuartpb changed the title What happens after changing a password? Reconciling password.reset.flow.submit and password.change Nov 5, 2016
@stuartpb
Copy link
Member Author

stuartpb commented Nov 5, 2016

This is a really sensible change, honestly - the only part that sticks out a bit for me is a kind of dumb one: making it so the two can easily be expressed non-redundantly, as expressed at #120 (comment).

Really, I'm leaning to the side of just "eh, it's not worth getting worked up over" and moving forward with this proposal: some kind of unifying change can be introduced later, and there's no reason to make the fear-of-maybe-not-being-as-perfect-as-possible be the enemy of the good here.

@stuartpb
Copy link
Member Author

stuartpb commented Nov 12, 2017

Well, in v0.1.0 there's password.reset.flow.change and password.reset.flow.submit, so I'd say this was resolved with #171 closing #163 and introducing a password.reset.flow.change.form that mirrors password.change.form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant