Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: cToken Wrapper and gas cost comparison #281

Closed
wants to merge 9 commits into from
Closed

Feature: cToken Wrapper and gas cost comparison #281

wants to merge 9 commits into from

Conversation

antoncoding
Copy link
Contributor

@antoncoding antoncoding commented Nov 3, 2020 •
edited
Loading

Task: Add CTokenProxy and mainnet test

High Level Description

  • CTokenProxy: Similar to payable proxy, but deal with wrapping cToken before executing tx.
  • Currently no unit test for this contract, only e2e (mainnet fork) test

Todos

  • Unit test 100% coverage
  • Does your code follow the naming and code documentation guidelines?
  • Is your code up to date with the spec?
  • Have you added your tests to the testing doc?

@antoncoding antoncoding self-assigned this Nov 3, 2020
@antoncoding antoncoding added the contract Smart contract implementations label Nov 3, 2020
@antoncoding antoncoding requested review from haythemsellami, aparnakr and aleone and removed request for haythemsellami November 5, 2020 07:35
@haythemsellami
Copy link
Member

We are not merging this one, right ?

@aleone
Copy link
Contributor

aleone commented Nov 24, 2020 via email

@antoncoding
Copy link
Contributor Author

We're not merging it, buy maybe we can put a archived label and close it?

@antoncoding antoncoding added this to In progress in Gamma via automation Nov 25, 2020
@antoncoding antoncoding added the archived Don't delete label Nov 25, 2020
Gamma automation moved this from In progress to Done Nov 25, 2020
@haythemsellami haythemsellami deleted the feature/gas-comparison branch January 10, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparnakr aparnakr Awaiting requested review from aparnakr

@haythemsellami haythemsellami Awaiting requested review from haythemsellami

@aleone aleone Awaiting requested review from aleone

Assignees

@antoncoding antoncoding

Labels
archived Don't delete contract Smart contract implementations
Projects
Gamma
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antoncoding @haythemsellami @aleone