Otoken: Burn and Mint #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparnakr
reviewed
Jul 24, 2020
| expiry = _expiry; | ||
| isPut = _isPut; | ||
| (string memory name, string memory symbol) = _getNameAndSymbol(); | ||
| __ERC20_init_unchained(name, symbol); |
There was a problem hiding this comment.
where are the decimals set?
There was a problem hiding this comment.
is set in the __ERC20_init_unchained function
function __ERC20_init_unchained(string memory name, string memory symbol) internal initializer {
_name = name;
_symbol = symbol;
_decimals = 18;
}
aparnakr
reviewed
Jul 24, 2020
aparnakr
reviewed
Jul 24, 2020
aparnakr
approved these changes
Jul 24, 2020
antoncoding
force-pushed
the
otoken-erc20
branch
from
db14729
to
7096c07
Compare
1 task
haythemsellami
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add
mintOtokenandburnOtokenfunctionsThis should be reviewed after #24 is merged, and change the based branch to master.
Todos: