Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict products #355

Merged
merged 11 commits into from Feb 17, 2021
Merged

Restrict products #355

merged 11 commits into from Feb 17, 2021

Conversation

aparnakr
Copy link
Contributor

Task: Restrict products

High Level Description

Only allow creating options products which are fully collateralized which won't require any liquidation mechanism.

Specific Changes
Added a require statement in whitelist to check that only put option products where the strike == collateral are allowed and call options where underlying == collateral are allowed.

Code

  • Unit test 100% coverage
  • Does your code follow the naming and code documentation guidelines?

Documentation

  • Is your code up to date with the spec?
  • Have you added your tests to the testing doc?

@antoncoding
Copy link
Contributor

Plz add tests for this line!

@haythemsellami haythemsellami changed the title Feature/restrict products Restrict products Jan 19, 2021
@haythemsellami
Copy link
Member

This will break the integration tests in Yield Farming: Naked Put Option closed before expiry flow, do u want to just ignore those for now by adding xit

@haythemsellami haythemsellami merged commit 6854a6b into master Feb 17, 2021
@haythemsellami haythemsellami deleted the feature/restrict-products branch February 17, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants