0x trading testing script #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding unit tests * clean * fix build * update mocks * clean * clean Co-authored-by: Haythem Sellami <sellamihaythem96@gmail.com>
haythemsellami
changed the title
haythemsellami
changed the title
|
@haythem96 can you rebase your branch to the current master? It's been containing commit message from last Dec 😂 |
aparnakr
reviewed
Feb 1, 2021
|
|
||
| console.log("Approving 0x Callee and calling Operate 🚀") | ||
|
|
||
| await callOption1.approve(trade0xCallee.address, optionsToMint, {from: taker}) |
There was a problem hiding this comment.
I thought we were going to use the permit callee for this approval?
There was a problem hiding this comment.
The Otoken in Kovan currently have no permit(), so I just used the approve()
aparnakr
reviewed
Feb 1, 2021
| expiryDate.setUTCSeconds(0) | ||
| expiry = new BigNumber(Math.floor(expiryDate.getTime() / 1000)) | ||
|
|
||
| let callOption1; |
There was a problem hiding this comment.
can we also test put options? :D
There was a problem hiding this comment.
IMO it is the same as the Trade0x is agnostic to what the option type is, it is the same asset/contract.
aparnakr
approved these changes
Feb 1, 2021
antoncoding
reviewed
Feb 3, 2021
antoncoding
reviewed
Feb 3, 2021
antoncoding
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: 0x trading testing script
High Level Description
This PR add a script to test Gamma actions batched with 0x trading on Kovan testnet.
The script use two address:
The Taker account need to have at least 1USDC and few ETH to approve USDC transfer.
The Maker account need to have at least 1ETH to collateralize the minted option + few ETH for 0x and transaction fees.
Also this PR add a bunch of scripts that help interacting with the protocol:
Usage:
truffle exec scripts/trade0x-kovan.js --network kovan --makerPrivateKey 0x0000...where
makerPrivateKeyis the account private key used to sign 0x order.Output:
Code
Documentation