Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarginAccount library #50

Merged
merged 34 commits into from
Aug 20, 2020
Merged

MarginAccount library #50

merged 34 commits into from
Aug 20, 2020

Conversation

haythemsellami
Copy link
Member

No description provided.

zkoticha and others added 19 commits July 22, 2020 15:01
@zkoticha
skeleton
cf3f5c3
@zkoticha
clearVault code added
6123d04
@zkoticha
preliminary outline of MarginAccount.sol
8e14106
@zkoticha
added dev doc notes
a2055ba
@zkoticha
improvements for safemath, fixed small bugs
826718d
@zkoticha
syntax issue
8ceb541
@zkoticha
safemath fixes
6881be6
@zkoticha
style and documentation improvements, @params
8678249
@zkoticha @aparnakr
Update contracts/MarginAccount.sol
3bad1d8 
Co-authored-by: aparnakr <aparnalocked@gmail.com>
@haythemsellami
Merge branch 'feature/MarginAccount' of github.com:opynfinance/GammaP…
6985ccb 
…rotocol into feature/MarginAccount
@haythemsellami
init unit testing
702f934
@zkoticha
MarginAccount test file udpated, MarginAccount added to libs folder
e291e49
@zkoticha
MarginAccount test file udpated, MarginAccount added to libs folder
db48319
@zkoticha
typescript MarginAccount testing file begun
5e67e16
@zkoticha
added ts and sol test files for marginAccount, not finished
91a04a6
@zkoticha
marginaccount zero_Addr fix for circleci
0f78fa0
@zkoticha
fixed an error in MarginAccount.test.ts, 2 vaultId should have been v…
e9a5727 
…alid
@haythemsellami
fix add short in MarginAccount
82d2aa1
@haythemsellami
update MarginAccount lib implementation
f549ffa
@haythemsellami haythemsellami mentioned this pull request Jul 29, 2020
Closed
aparnakr
aparnakr reviewed Aug 1, 2020
View reviewed changes
test/MarginAccount.test.ts Outdated Show resolved Hide resolved
aparnakr
aparnakr reviewed Aug 1, 2020
View reviewed changes
test/MarginAccount.test.ts Outdated Show resolved Hide resolved
aparnakr
aparnakr reviewed Aug 1, 2020
View reviewed changes
test/MarginAccount.test.ts Outdated Show resolved Hide resolved
aparnakr
aparnakr reviewed Aug 1, 2020
View reviewed changes
test/MarginAccount.test.ts Outdated Show resolved Hide resolved
aparnakr
aparnakr reviewed Aug 1, 2020
View reviewed changes
test/MarginAccount.test.ts Outdated Show resolved Hide resolved
aparnakr
aparnakr reviewed Aug 1, 2020
View reviewed changes
test/MarginAccount.test.ts Outdated Show resolved Hide resolved
aparnakr
aparnakr reviewed Aug 1, 2020
View reviewed changes
test/MarginAccount.test.ts Outdated Show resolved Hide resolved
aparnakr
aparnakr reviewed Aug 1, 2020
View reviewed changes
test/MarginAccount.test.ts Outdated Show resolved Hide resolved
aparnakr
aparnakr approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@aparnakr aparnakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge after resolving all the last TODOs and comments

@antoncoding antoncoding added the contract Smart contract implementations label Aug 3, 2020
@haythemsellami haythemsellami changed the title Outline of MarginAccount library MarginAccount library Aug 20, 2020
@haythemsellami haythemsellami self-assigned this Aug 20, 2020
@antoncoding antoncoding merged commit 0871b4b into master Aug 20, 2020
@antoncoding antoncoding deleted the feature/marginaccount-lib branch September 3, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoncoding antoncoding antoncoding approved these changes

@zkoticha zkoticha Awaiting requested review from zkoticha

@aparnakr aparnakr Awaiting requested review from aparnakr

@aleone aleone Awaiting requested review from aleone

Assignees

@zkoticha zkoticha

@haythemsellami haythemsellami

Labels
contract Smart contract implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haythemsellami @zkoticha @aparnakr @antoncoding