adds early return if no pending event is present

closes prooph#42
oqq · Jan 4, 2017 · ecc932d · ecc932d
1 parent f26bc80
commit ecc932d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/Aggregate/AggregateRepository.php b/src/Aggregate/AggregateRepository.php
@@ -92,9 +92,13 @@ public function saveAggregateRoot($eventSourcedAggregateRoot): void
 
         $createStream = false;
 
-        $firstEvent = $domainEvents[0];
+        $firstEvent = reset($domainEvents);
 
-        if ($this->isFirstEvent($firstEvent) && $this->oneStreamPerAggregate) {
+        if (false === $firstEvent) {
+            return;
+        }
+
+        if ($this->oneStreamPerAggregate && $this->isFirstEvent($firstEvent)) {
             $createStream = true;
         }
 

diff --git a/tests/Aggregate/AggregateRepositoryTest.php b/tests/Aggregate/AggregateRepositoryTest.php
@@ -461,4 +461,15 @@ public function it_used_provided_stream_name(): void
 
         $this->repository->saveAggregateRoot($user);
     }
+
+    /**
+     * @test
+     * @see https://github.com/prooph/event-sourcing/issues/42
+     */
+    public function it_does_not_throw_an_exception_if_no_pending_event_is_present()
+    {
+        $user = User::create('John Doe', 'contact@prooph.de');
+        $this->repository->saveAggregateRoot($user);
+        $this->repository->saveAggregateRoot($user);
+    }
 }