Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a topological sort of variable bindings when building the beta tree #133

Closed
rbrush opened this issue Oct 18, 2015 · 1 comment
Closed
Milestone

Comments

@rbrush
Copy link
Contributor

rbrush commented Oct 18, 2015

The sort order for rule constraints is somewhat arbitrary and confusing, as can be seen in the clara.rules.compiler/condition-comp function, and accumulators that use the result bindings of other accumulators in the same rule may yield an error on compilation time.

We can address this by doing a topologic sort on the variable bindings used by conditions. This issue is to evaluate and track that effort.

@rbrush
Copy link
Contributor Author

rbrush commented Nov 13, 2015

Closing! This has been merged into master.

@rbrush rbrush closed this as completed Nov 13, 2015
@rbrush rbrush added this to the 0.9.1 milestone Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant