-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should TypeSystem#value have a default value? #48
Comments
Agreed. This is an artifact from a time where types in the type system where mandatory. Feel free to push the change (should not require a change in the processor). Otherwise I can push it with my next Truffle changeset. |
Just wondering, what is the concrete use of From the javadoc, I would assume it helps the DSL to keep specializations of different node hierarchies separated. |
|
You mean the But, what was |
JRuby uses If something needs more documentation that's a separate issue to adding this default value. |
The only use-case for having the types specified in I was tempted in the past to deprecate the typesystem types all together because the benefit is rather small. Objections? Yes documentation also needs to be updated. Will do as part of this issue. |
I don't mind it being deprecated as I'm not using it. |
Isn't it the case that the list of types used in the DSL type system is largely redundant now? So at least should it be given a default value of
{}
so that we can write:instead of
The text was updated successfully, but these errors were encountered: