Missing @NodeInfo(shortName = "in") for js/nodes/binary/InNode

[BarrensZeppelin]

Is there a reason why the binary InNode doesn't have a NodeInfo annotation?

graaljs/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/binary/InNode.java

Lines 62 to 63 in ce00493

	public abstract class InNode extends JSBinaryNode {

Many of the other binary nodes have them, such as JSAddNode:

graaljs/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/binary/JSAddNode.java

Lines 77 to 78 in ce00493

	@NodeInfo(shortName = "+")
	public abstract class JSAddNode extends JSBinaryNode implements Truncatable {

[iamstolis]

Is there a reason why the binary InNode doesn't have a NodeInfo annotation?

No particular reason, we can add it, I guess. Could you, please, elaborate a bit on why do you need it/how have you discovered that it is not there? Thank you in advance.

[BarrensZeppelin]

Hi!
NodeProf.js uses the shortName (which is assigned to the operator key in JSBinaryNode.getNodeObject()) to identify which binary operation that is instrumented (profiled).
https://github.com/Haiyang-Sun/nodeprof.js/blob/master/src/ch.usi.inf.nodeprof/src/ch/usi/inf/nodeprof/handlers/BinaryEventHandler.java#L35

[iamstolis]

Thank you for the additional details. I have added @NodeInfo annotation to InNode (and to two other nodes) in e8c3685.