-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MP 3.2; add full and core MP bundles and deprecate existing numbered ones #1143
Conversation
…d bump mp version to 3.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the other modules, that depended on older MP versions, we should switch to microprofile-core
and add only required specs (e.g. for TCK tests).
@@ -41,7 +41,7 @@ | |||
<dependencies> | |||
<dependency> | |||
<groupId>io.helidon.microprofile.bundles</groupId> | |||
<artifactId>helidon-microprofile-3.1</artifactId> | |||
<artifactId>helidon-microprofile-core</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be full microprofile as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One benefit of doing what you suggest is that users can then use any of the MP technologies if they use the example pom
, without having to change which bundle they reference.
The cost is the possible confusion as to why the example - which actually only requires core
- declares a dependency on the full bundle.
I assume you are OK with that trade-off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a basic example that shows how to start MP. I expect people use example as a first step to use Helidon - e.g. it is expected that additional MP specs will be used.
</description> | ||
|
||
<dependencies> | ||
<dependency> | ||
<groupId>io.helidon.microprofile.bundles</groupId> | ||
<artifactId>helidon-microprofile-3.1</artifactId> | ||
<artifactId>helidon-microprofile-core</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be full microprofile
…o io.helidon.security.integration:helidon-security-integration-jersey-client (needed to pass our MP security test and for most common use cases)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…l test, which relies on the MP bookstore app, will find the endpoints it expects
As part of support for MicroProfile 3.2 we are adding two new MP bundles:
helidon-microprofile-core
(basically what's needed for the server) andhelidon-microprofile
(everything).We are also deprecating (but not yet removing) the bundles numbered after the MP version numbers.
The coding changes add the new bundles and also update all dependencies in Helidon that used to refer to the 3.1 MP bundle. The javadoc component had a dependency on the 1.2 bundle that has also been updated.
There are a few components (not included in this PR) which currently depend on some earlier (pre-3.1) MP bundle. We will need to decide for each what to do when we actually remove the numbered bundles in a future Helidon release: