Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move onXXX from Subscribable to Single + TCK #1477

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Move onXXX from Subscribable to Single + TCK #1477

merged 1 commit into from
Mar 10, 2020

Conversation

akarnokd
Copy link
Collaborator

@akarnokd akarnokd commented Mar 9, 2020

Move onTerminate, onError and onComplete from Subscribable into Single to have the proper return type.

Add peek to Single as well.

Related: #1455.

@akarnokd akarnokd mentioned this pull request Mar 9, 2020
Closed
13 tasks
@danielkec danielkec self-assigned this Mar 10, 2020
@danielkec danielkec added the reactive Reactive streams and related components label Mar 10, 2020
@danielkec danielkec added this to the 2.0.0 milestone Mar 10, 2020
@danielkec danielkec merged commit c50959f into helidon-io:master Mar 10, 2020
@akarnokd akarnokd deleted the SubscribableMoveOut1 branch March 25, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkec danielkec danielkec approved these changes

Assignees

@danielkec danielkec

Labels
reactive Reactive streams and related components
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akarnokd @danielkec