Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dynamically-registered apps in just-in-time jandex index 2.x #1555

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Include dynamically-registered apps in just-in-time jandex index 2.x #1555

merged 1 commit into from
Mar 23, 2020

Conversation

tjquinno
Copy link
Member

Resolves #1542

When we build a just-in-time Jandex index (if the developer did not build one as part of the app JAR), we use a CDI extension that responds to each annotated type. This misses any Application classes that lack a bean-defining annotation.

This PR augments the just-in-time index with any such classes that were dynamically registered with the server.

…egistered with the server that might have eluded annotation scanning (e.g., no bean-defining annotation)
@tjquinno tjquinno added open-api 2.x Issues for 2.x version branch labels Mar 20, 2020
@tjquinno tjquinno self-assigned this Mar 20, 2020
@tjquinno tjquinno changed the title Include dynamically-registered apps in just-in-time jandex index Include dynamically-registered apps in just-in-time jandex index 2.x Mar 20, 2020
@tjquinno tjquinno merged commit e1c9e07 into helidon-io:master Mar 23, 2020
@tjquinno tjquinno deleted the openapi-missed-app branch March 23, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch open-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI without jandex index ignores application path annotation on explicit apps.
2 participants