Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: use application pom, clean up READMEs #1680

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Examples: use application pom, clean up READMEs #1680

merged 3 commits into from
Apr 29, 2020

Conversation

barchetta
Copy link
Member

No description provided.

@barchetta barchetta added the 2.x Issues for 2.x version branch label Apr 22, 2020
@barchetta barchetta self-assigned this Apr 22, 2020
tjquinno
tjquinno approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I focused on the OpenAPI changes.

Verdent
Verdent approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@Verdent Verdent left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebClient changes look good. Thank you!

@barchetta barchetta merged commit e767c45 into helidon-io:master Apr 29, 2020
@barchetta barchetta deleted the example-fixes branch May 4, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Verdent Verdent Verdent approved these changes

@tjquinno tjquinno tjquinno approved these changes

Assignees

@barchetta barchetta

Labels
2.x Issues for 2.x version branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barchetta @Verdent @tjquinno