Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataChunk ByteBuffer array #1877

Merged
merged 9 commits into from
Jun 2, 2020
Merged

DataChunk ByteBuffer array #1877

merged 9 commits into from
Jun 2, 2020

Conversation

romain-grecourt
Copy link
Contributor

@romain-grecourt romain-grecourt commented May 27, 2020 •
edited

Update DataChunk to hold an array of ByteBuffer instead of a single ByteBuffer.

Fixes #1876

@romain-grecourt romain-grecourt changed the title Update DataChunk to hold an array of ByteBuffer instead of a single B… DataChunk ByteBuffer array May 27, 2020
tomas-langer
tomas-langer previously approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas self-requested a review May 27, 2020 14:15
@barchetta barchetta added this to the 2.0.0-RC1 milestone May 28, 2020
spericas
spericas previously approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the version better. Perhaps we can later simplify DataChunkInputStream::read a bit to make it more readable.

@romain-grecourt romain-grecourt merged commit a9363a3 into helidon-io:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

@spericas spericas spericas left review comments

@tomas-langer tomas-langer tomas-langer left review comments

Assignees

@romain-grecourt romain-grecourt

Labels
None yet
Projects
None yet
Milestone
2.0.0-RC1
Development

Successfully merging this pull request may close these issues.

DataChunk as iterable of ByteBuffer
4 participants
@romain-grecourt @spericas @barchetta @tomas-langer