Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helidon Istio Example #3676

Merged
merged 5 commits into from Nov 30, 2021
Merged

Conversation

arjav-desai
Copy link
Member

Adding an example showcasing how you can setup Helidon microservices inside Istio service mesh and setup communication amongst services inside mesh as well as access a service from outside the mesh.

tjquinno and others added 3 commits November 26, 2021 18:23
…icsSettings (helidon-io#3659)

* Add test for overall disabled metrics

* Defer creating the RegistryFactory INSTANCE until first actual retrieval so as to use the latest-provided MetricsSettings

* Reorder some code so the metrics CDI initialized the RegistryFactory with the correct MetricsSettings before the producer 'clearApplicationRegistry' method is invoked
…access to RegistryFactory (helidon-io#3663)

* Set initial MetricsSettings for creating RegistryFactory from config; still can be changed by later calls to getInstance(MetricsSettings)

* Need to support no-op Gauge after all

* Defer use of RegistryFactory as long as possible for executor metrics

* Reorder some steps in MP metrics service initialization

* In MP fault tolerance, defer access to RegistryFactory

* In Jaeger metrics defer access to RegistryFactory

* In DB client defer access to RegistryFactory

* In grpc defer access to RegistryFactory

* Add MP/metrics test for disabled metrics
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjav-desai arjav-desai merged commit 5b670e4 into helidon-io:helidon-2.x Nov 30, 2021
@barchetta barchetta added this to the 2.4.1 milestone Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants