Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCI vault examples switched to OCI SDK from custom OCI integration. #4084

Merged
merged 5 commits into from
Apr 1, 2022
Merged

OCI vault examples switched to OCI SDK from custom OCI integration. #4084

merged 5 commits into from
Apr 1, 2022

Conversation

tomas-langer
Copy link
Member

Related to #3986

Vault examples updated

  • CDI example now uses injection of clients + a customized error handler + a customized builder producer
  • reactive example now uses async OCI SDK clients

Signed-off-by: Tomas Langer tomas.langer@oracle.com

@tomas-langer
OCI vault examples switched to OCI SDK from custom OCI integration.
f761afb 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer added 2.x Issues for 2.x version branch OCI labels Mar 30, 2022
@tomas-langer tomas-langer self-assigned this Mar 30, 2022
ljnelson
ljnelson requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor things

@tomas-langer
Review fixes.
f70c1ed 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@barchetta barchetta added this to the 2.4.3 milestone Mar 30, 2022
barchetta
barchetta reviewed Mar 31, 2022
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests even if all they do is start the application? I know that doesn't do much, but it would at least catch some runtime dependency issues (like if Joe removes the jakarta.inject dependency from the vault-reactive pom).

examples/integrations/oci/vault-reactive/pom.xml Outdated Show resolved Hide resolved
@tomas-langer
Copy link
Member Author

I cannot add a startup test for SE:

Exception in thread "main" java.io.IOException: Can't load the default config from '/home/tomas/.oci/config' or '/home/tomas/.oraclebmc/config' because it does not exist or it is not a file.

Will add for MP (as it can start without authentication provider)

@tomas-langer
Review fixes.
d3313ad 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Checkstyle fix.
43f3f16 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
barchetta
barchetta previously approved these changes Mar 31, 2022
View reviewed changes
ljnelson
ljnelson previously approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tiny things that you could fix or not depending

@tomas-langer
Review fixes.
30b0617 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer dismissed stale reviews from ljnelson and barchetta via 30b0617 April 1, 2022 13:15
@barchetta barchetta merged commit 68bf829 into helidon-io:helidon-2.x Apr 1, 2022
@tomas-langer tomas-langer deleted the 3986-oci-vault branch July 11, 2022 16:08
@arjav-desai arjav-desai mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljnelson ljnelson ljnelson approved these changes

@barchetta barchetta Awaiting requested review from barchetta

Assignees

@tomas-langer tomas-langer

Labels
2.x Issues for 2.x version branch OCI
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomas-langer @ljnelson @barchetta