-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCI vault examples switched to OCI SDK from custom OCI integration. #4084
Conversation
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
...ci/vault-cdi/src/main/java/io/helidon/examples/integrations/oci/vault/cdi/VaultResource.java
Outdated
Show resolved
Hide resolved
...t-reactive/src/main/java/io/helidon/examples/integrations/oci/vault/reactive/OciHandler.java
Outdated
Show resolved
Hide resolved
...reactive/src/main/java/io/helidon/examples/integrations/oci/vault/reactive/VaultService.java
Outdated
Show resolved
Hide resolved
...reactive/src/main/java/io/helidon/examples/integrations/oci/vault/reactive/VaultService.java
Outdated
Show resolved
Hide resolved
examples/integrations/oci/vault-reactive/src/main/resources/application.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor things
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests even if all they do is start the application? I know that doesn't do much, but it would at least catch some runtime dependency issues (like if Joe removes the jakarta.inject dependency from the vault-reactive pom).
I cannot add a startup test for SE:
Will add for MP (as it can start without authentication provider) |
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
...ci/vault-cdi/src/main/java/io/helidon/examples/integrations/oci/vault/cdi/VaultResource.java
Outdated
Show resolved
Hide resolved
...t-reactive/src/main/java/io/helidon/examples/integrations/oci/vault/reactive/OciHandler.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of tiny things that you could fix or not depending
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Related to #3986
Vault examples updated
Signed-off-by: Tomas Langer tomas.langer@oracle.com