Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension is providing incorrect quickfix code actions #153

Closed
robaho opened this issue Apr 26, 2024 · 9 comments
Closed

extension is providing incorrect quickfix code actions #153

robaho opened this issue Apr 26, 2024 · 9 comments
Labels
Apache-Netbeans bug Something isn't working
Milestone

Comments

@robaho
Copy link

robaho commented Apr 26, 2024

I see this in the extension host logs:

2024-04-25 20:33:33.896 [warning] Oracle.oracle-java - Code actions of kind 'quickfix 'requested but returned code action is of kind 'refactor.rewrite'. Code action will be dropped. Please check 'CodeActionContext.only' to only return requested code actions.

This is using the latest v22.0

@Achal1607
Copy link
Member

Can you please provide steps to reproduce the issue where you got incorrect quick actions?

@robaho
Copy link
Author

robaho commented Apr 26, 2024

I am not really sure. I keep getting a popup message like "Element with id 17 is already registered" - which I "think" is a gradle issue - but in looking through the logs to see what might be causing this I found those warnings, so I thought I would report it.

@Achal1607
Copy link
Member

Because the warnings log that you have shared were present in previous version of extensions as well, so problem is faced with quickfix code actions or some gradle issue is there? Can you please clarify this.

@robaho
Copy link
Author

robaho commented Apr 26, 2024

I noticed the message in the logs - which seems to indicate there is a problem with the quickactions code in the extension. I don't have any more details than that - sorry.

@Achal1607 Achal1607 added the In-Progress For the issues being worked on label May 8, 2024
@Achal1607
Copy link
Member

FYI: PR raised on the netbeans side: apache/netbeans#7368

@Achal1607 Achal1607 added Apache-Netbeans patch-ready-YTD The code has been merged in the branch/fix ready, release yet to happen and removed In-Progress For the issues being worked on labels May 10, 2024
@Achal1607
Copy link
Member

Fix available in NB-23

@robaho
Copy link
Author

robaho commented May 14, 2024

Nice work!

@arvindaprameya arvindaprameya added the bug Something isn't working label May 15, 2024
@arvindaprameya arvindaprameya added this to the JVSC-22.0.1 milestone May 15, 2024
@Almushki
Copy link

اريد كود حساب اسم معين

@Achal1607 Achal1607 removed this from the JVSC-22.0.1 milestone May 20, 2024
@Achal1607
Copy link
Member

Merged

@Achal1607 Achal1607 removed the patch-ready-YTD The code has been merged in the branch/fix ready, release yet to happen label Jun 17, 2024
@Achal1607 Achal1607 added this to the JVSC 22.1.1 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apache-Netbeans bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants