Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.0 with ReactiveCrudRepository #30

Closed
sashuki opened this issue Jun 16, 2021 · 5 comments
Closed

v0.2.0 with ReactiveCrudRepository #30

sashuki opened this issue Jun 16, 2021 · 5 comments

Comments

@sashuki
Copy link

sashuki commented Jun 16, 2021

Recently, I updated oracle r2dbc to v 0.2.0 and no queries are able to execute. It just hangs.
last records in logs

2021-06-16 23:16:18,861 [reactor-http-nio-4] DEBUG org.springframework.core.log.LogFormatUtils [traceDebug] [reactor-http-nio-4] [] : [acae8c1f-1, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:53282] HTTP GET "/api/getToken?token=asdasd"
2021-06-16 23:16:18,878 [reactor-http-nio-4] DEBUG org.springframework.web.reactive.handler.AbstractHandlerMapping [lambda$getHandler$1] [reactor-http-nio-4] [] : [acae8c1f-1, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:53282] Mapped to acme.TokenController#request(String)
2021-06-16 23:16:20,482 [ForkJoinPool.commonPool-worker-3] DEBUG org.springframework.r2dbc.core.DefaultDatabaseClient$DefaultGenericExecuteSpec [lambda$execute$2] [ForkJoinPool.commonPool-worker-3] [] : Executing SQL statement [SELECT ssn.ssn_id, ssn.a_tkn, ssn.a_typ, ssn.a_id, ssn.a_sbj FROM ssn WHERE ssn.a_tkn = :P0_atkn]

after the last record, it is just hangs

If I change the version back, it works

I am using ReactiveCrudRepository and spring-boot-starter-data-r2dbc

@Michael-A-McMahon
Copy link
Member

Thanks for this report.

Can you let me know which method of ReactiveCrudRepository is called? Also, how many rows would you expect the query to return? 0, 1, many? This information will help me debug.

@Michael-A-McMahon
Copy link
Member

Michael-A-McMahon commented Jun 16, 2021

Would you be able to share some code that recreates the hang? I'm not sure how to do it.

I tried a few tests with ReactiveCrudRepository, but could not recreate the hang.
I also tried out a demo which references spring-boot-starter-data-r2dbc, but this didn't create the hang either:
https://spring.io/guides/gs/accessing-data-r2dbc/

@mp911de
Copy link

mp911de commented Jun 17, 2021

I think this is because Oracle R2DBC 0.2.0 migrated to R2DBC SPI 0.9 already while Spring Framework and Spring Data are using the older SPI 0.8 baseline.

@Michael-A-McMahon
Copy link
Member

Thanks, @mp911de. At least for now, Spring users like @sashuki should stick with v0.1.0 of Oracle R2DBC.

@Michael-A-McMahon
Copy link
Member

Closing this issue as Spring does not currently support the 0.9.0 SPI used by v0.2.0 of Oracle R2DBC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants