Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Gradle dependency is not correct #49

Closed
galimru opened this issue Sep 28, 2020 · 4 comments
Closed

Documentation for Gradle dependency is not correct #49

galimru opened this issue Sep 28, 2020 · 4 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@galimru
Copy link

galimru commented Sep 28, 2020

Describe the bug

The way of adding Gradle dependency in the documentation is not correct.
This is because it loads only the pom file itself but not all transient jars.

I had to add transitive property to make it work.

    api ('org.tribuo:tribuo-all:4.0.0@pom') {
        transitive = true
    }

System information:

  • OS: macOS 10.15.6
  • Java Version: 1.8.0_231
  • JDK Vendor: Oracle
@galimru galimru added the bug Something isn't working label Sep 28, 2020
@Craigacp Craigacp added the documentation Improvements or additions to documentation label Sep 28, 2020
@Craigacp
Copy link
Member

Craigacp commented Sep 28, 2020

api is only available in java-library, so implementation or compile are the options which work across both the java and java-library plugins. I hadn't realised gradle treated pom dependencies differently (previously our distribution target made a with dependencies jar itself, but that wasn't compatible with maven central) and we must have missed the check when we converted it from a jar to a pom dependency before release. I can update it to implementation with the transitive flag.

Do you know if the syntax is the same across Groovy & Kotlin gradle files?

@galimru
Copy link
Author

galimru commented Sep 28, 2020

Just checked with Kotlin and it uses a bit different property isTransitive :

    implementation ("org.tribuo:tribuo-all:4.0.0@pom") {
        isTransitive = true
    }

@Craigacp
Copy link
Member

Ok, I'll make it clear that it's specific to Groovy in the docs. I don't really want to add a fourth tab to the homepage for the two different ways of saying it in Gradle.

@jhalexand
Copy link
Member

I've fixed this in the website repo. The gradle dependency now sets transitive appropriately and shows the variation for Kotlin. Tested in new gradle-groovy and gradle-kotlin projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants