Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib issue: External LLVMFunction rb_lastline_set cannot be found #2170

Closed
gogainda opened this issue Nov 23, 2020 · 4 comments
Closed

zlib issue: External LLVMFunction rb_lastline_set cannot be found #2170

gogainda opened this issue Nov 23, 2020 · 4 comments
Assignees
Milestone

Comments

@gogainda
Copy link
Contributor

 1) Error:
TestZlibGzipFile#test_lineno:
RuntimeError: External LLVMFunction rb_lastline_set cannot be found. (com.oracle.truffle.llvm.runtime.except.LLVMLinkerException)
Translated to internal error
    /Users/novoi/tmp/zlib/ext/zlib/zlib.c:4324:in `rb_gzreader_gets'
    /Users/novoi/.rubies/truffleruby-dev/lib/truffle/truffle/cext_ruby.rb:39:in `gets'
    /Users/novoi/tmp/zlib/test/zlib/test_zlib.rb:644:in `block (2 levels) in test_lineno'
    /Users/novoi/.rubies/truffleruby-dev/lib/truffle/truffle/cext.rb:1003:in `rb_yield'
    call.c:70:in `rb_yield'
    /Users/novoi/.rubies/truffleruby-dev/lib/truffle/truffle/cext.rb:1462:in `rb_ensure'
    exception.c:68:in `rb_ensure'
    /Users/novoi/tmp/zlib/ext/zlib/zlib.c:3131:in `gzfile_wrap'
    /Users/novoi/tmp/zlib/ext/zlib/zlib.c:3173:in `gzfile_s_open'
    /Users/novoi/tmp/zlib/ext/zlib/zlib.c:3792:in `rb_gzreader_s_open'
    /Users/novoi/.rubies/truffleruby-dev/lib/truffle/truffle/cext_ruby.rb:39:in `open'
    /Users/novoi/tmp/zlib/test/zlib/test_zlib.rb:643:in `block in test_lineno'
    /Users/novoi/.rubies/truffleruby-dev/lib/mri/tempfile.rb:332:in `create'
    /Users/novoi/tmp/zlib/test/zlib/test_zlib.rb:639:in `test_lineno'

To reproduce:

git clone git@github.com:ruby/zlib.git 
cd zlib
bundle install
bundle exec rake
@eregon
Copy link
Member

eregon commented Nov 23, 2020

Is TruffleRuby tested in https://github.com/ruby/zlib or is there a PR for it? Where does this run come from?

Anyway, good thing to fix, and we should be able to untag the corresponding MRI test.
@aardvark179 Can you take care of this one?

@eregon eregon added this to the 21.0.0 milestone Nov 23, 2020
@gogainda
Copy link
Contributor Author

zlib is not tested against truffleruby, I just run it locally

@gogainda
Copy link
Contributor Author

There is a good discussion how to decrease MEM usage: ruby/zlib#19 (comment)

@eregon eregon removed this from the 21.0.0 milestone Jan 14, 2021
@eregon
Copy link
Member

eregon commented Jan 25, 2021

rb_lastline_set implemented in b46b9b7 by @aardvark179.

@eregon eregon closed this as completed Jan 25, 2021
@eregon eregon added this to the 21.1.0 milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants