Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should +R prevent unauthenticated users from joining the channel? #463

Closed
slingamn opened this issue Apr 25, 2019 · 5 comments
Closed

should +R prevent unauthenticated users from joining the channel? #463

slingamn opened this issue Apr 25, 2019 · 5 comments
Assignees
Milestone

Comments

@slingamn
Copy link
Member

Right now, it looks like +R allows unauthenticated users to join the channel, but forbids them to speak.

It seems like we should prevent them from joining altogether, because they can still spam the channel via NICK changes.

h/t @bogdomania

@bogdomania
Copy link

+r -> (channel mode) prevents users not auth'd with services to join a channel(ircd-seven) that has this mode enabled;
+R -> (user mode) prevents users not auth'd with services to PM(Unreal) you, if you /mode <me> +R;

@slingamn
Copy link
Member Author

Note: irc/modes/modes.go defines +r as "Restricted" but we don't use it anywhere yet.

@DanielOaks
Copy link
Member

Yeah if the mode already forbids them to speak, it should forbid them from joining as well. I believe the 'logic' there is that really it 'bans' those users from the channel, and banned users can't speak or join the channel.

@slingamn slingamn added this to the v1.1 milestone May 12, 2019
@slingamn slingamn self-assigned this May 12, 2019
@slingamn
Copy link
Member Author

Should an invite except you from this restriction?

@slingamn
Copy link
Member Author

I'm going with "yes".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants