built-in option improvements

orakist · Jan 26, 2024 · 3db6852 · 3db6852
1 parent 809c4f8
commit 3db6852
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -636,7 +636,7 @@ These are command line options of this application.
 Usage: [-n (value)] [-c <value>]
 ```
 
-To print hidden options too, set verbosity level to detailed or trace. See the following output --verbosity is a hidden option. For example:
+To print hidden options too, set verbosity level to detailed or trace. See the following help output with hidden options:
 
 ```console
 ./> --help --vl:detailed

diff --git a/src/Oaksoft.ArgumentParser/Builder/ArgumentParserBuilder.cs b/src/Oaksoft.ArgumentParser/Builder/ArgumentParserBuilder.cs
@@ -188,6 +188,7 @@ private void BuildVersionOption()
         option.SetName(nameof(IBuiltInOptions.Version), false);
         option.SetValidAliases(validAliases);
         option.SetDescription("Shows version-number of the application.");
+        ((BaseValueOption)option).SetValueArity(ArityType.Zero);
     }
 
     private void BuildHelpOption()
@@ -211,6 +212,7 @@ private void BuildHelpOption()
         option.SetName(nameof(IBuiltInOptions.Help), false);
         option.SetValidAliases(validAliases);
         option.SetDescription("Shows help and usage information.");
+        ((BaseValueOption)option).SetValueArity(ArityType.Zero);
     }
 
     private void BuildVerbosityOption()

diff --git a/test/Oaksoft.ArgumentParser.Tests/ConfigTests/OptionRegistrationTests.cs b/test/Oaksoft.ArgumentParser.Tests/ConfigTests/OptionRegistrationTests.cs
@@ -45,22 +45,6 @@ public void ShouldParseHelp_WhenHelpInputIsTrue()
         parser.IsHelpOption.ShouldBeTrue();
     }
 
-    [Fact]
-    public void ShouldParseHelp_WhenHelpInputIsFalse()
-    {
-        // Arrange
-        var sut = CommandLine.CreateParser<SampleOptionNames>()
-            .AddNamedOption(s => s.Value);
-
-        // Act & Assert
-        var parser = sut.Build();
-        parser.Parse("-h:false");
-
-        var builtInOpts = parser.GetBuiltInOptions();
-        builtInOpts.Help.ShouldBe(false);
-        parser.IsHelpOption.ShouldBeFalse();
-    }
-
     [Fact]
     public void ShouldCreateError_WhenHelpInputIsNotValid()
     {