Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker is picking the blue color from the lineout of the selected pixel. #28

Closed
azagaya opened this issue Nov 28, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@azagaya
Copy link
Contributor

azagaya commented Nov 28, 2019

Hi!
Sometimes, when picking a color, the color picker from godot picks the color of the lineout:

imagen

IDK if this can be solved easily.

@OverloadedOrama
Copy link
Member

Good eye! I have noticed that myself as well. I'm not sure how this can be solved, since all the logic is being handled by Godot's color picker. However, I plan to eventually create a custom color picker with a color-selector-from-screen tool which will get the color of the pixel on the mouse's position. This should be fairly easy to do.

@azagaya
Copy link
Contributor Author

azagaya commented Nov 29, 2019

In the meantime, until you make the custom color picker, you could not draw the blue rect if Global.can_draw is false. I made the test, and imho is more comfortable this way, as picking blue accidentally makes you (at best) have to go and pick color again. I can make a PR for you for this, so you can test even if you are not interested in this change.

@OverloadedOrama
Copy link
Member

That sounds very interesting actually. A PR would be appreciated!

@azagaya
Copy link
Contributor Author

azagaya commented Nov 29, 2019

You could also use warp_mouse() to move mouse always to the center of a pixel, but i think its a bit more complicated, cause you'll have to handle different rates when zooming and so.

@OverloadedOrama
Copy link
Member

That could work, but I think your PR solved the problem already, so I guess I'll close this issue as well. Thank you for the contribution! :D

@azagaya
Copy link
Contributor Author

azagaya commented Nov 29, 2019

You are welcome! glad to help

@OverloadedOrama OverloadedOrama added the bug Something isn't working label Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants