Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks(repackage_boshreleases_fallback): fix deserialization #443

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

o-orand
Copy link
Member

@o-orand o-orand commented Nov 29, 2023

As of Ruby 3.1, if you use YAML.load_file, you must explicitly list the classes that are allowed for deserialization.
Otherwise, a Psych::DisallowedClass error will be thrown.

Fixes #442

Changes proposed in this pull-request:

  • add BoshCliError to allowed classes for deserilization
  • add test to illustrate the error

@o-orand o-orand added this to the 6.1.4 milestone Nov 29, 2023
@o-orand o-orand force-pushed the fix-repackage-boshreleases-fallback-parsing-error branch from 55b1098 to b68f395 Compare November 30, 2023 10:21
As of Ruby 3.1, if you use YAML.load_file, you must explicitly list the classes that are allowed for deserialization.
Otherwise, a `Psych::DisallowedClass` error will be thrown.
@o-orand o-orand force-pushed the fix-repackage-boshreleases-fallback-parsing-error branch from b68f395 to a230a35 Compare March 19, 2024 08:45
@o-orand o-orand self-assigned this Mar 19, 2024
@o-orand o-orand merged commit 18ee75a into develop Mar 19, 2024
2 of 3 checks passed
@o-orand o-orand deleted the fix-repackage-boshreleases-fallback-parsing-error branch March 19, 2024 09:48
o-orand added a commit that referenced this pull request Mar 20, 2024
Follow up of #443. UT were failing due to missing '`initialize': uninitialized constant RepackageReleasesFallback::Tasks (NameError)'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precompile pipeline handle bosh error during push-bosh job in repackage-releases-fallback task
1 participant