Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed minor typo where the "GLUNIFORM2FVFN" extension had been used where it wasn't intended #48

Merged
merged 1 commit into from
Dec 15, 2019

Conversation

d4v3y5c0n3s
Copy link
Contributor

Previously, "GLUNIFORM2FVFN" had been used where "GLUNIFORM3FVFN" and "GLUNIFORM3FVFN" should have been used instead on lines 148 & 149.

Previously, "GLUNIFORM2FVFN" had been used where "GLUNIFORM3FVFN" and "GLUNIFORM3FVFN" should have been used instead on lines 148 & 149.
@d4v3y5c0n3s
Copy link
Contributor Author

Also, quickly compiled the engine with the changes and encountered no errors. I will test compiling the demos and report whether they also work with the changes or not.

@d4v3y5c0n3s d4v3y5c0n3s reopened this Dec 15, 2019
@d4v3y5c0n3s
Copy link
Contributor Author

Oops, accidentally closed it there. My bad.

@d4v3y5c0n3s
Copy link
Contributor Author

In order to test the demos I think that I need to add libcorange to my path. I'll do that later unless you test the demos first. Hopefully this minor fix will get merged. :)

@orangeduck orangeduck merged commit eaace0f into orangeduck:master Dec 15, 2019
@orangeduck
Copy link
Owner

Thanks a lot. Looks like a copy-paste error so I'm sure it will be fine without testing the demos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants