OHRM5X-1734: Buzz share video component #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManulMax
approved these changes
Oct 24, 2022
RajithaKumara
approved these changes
Oct 24, 2022
| }, | ||
| }, | ||
| computed: { | ||
| embedURL() { |
There was a problem hiding this comment.
shall we move these logic & validation to BE?
🤔
There was a problem hiding this comment.
Sure, but we will possibly need 2 APIs.
- For validation of user input URL
- To extract video ID of the user input URL (we need only the video ID for embed frame and since there are multiple formats of URL we need a regex to match pattern and extract the ID)
RajithaKumara
pushed a commit
to RajithaKumara/orangehrm
that referenced
this pull request
Oct 24, 2022
* OHRM5X-1737: Refactor buzz post components
Super-Chama
pushed a commit
to Super-Chama/orangehrm
that referenced
this pull request
Dec 13, 2022
* OHRM5X-1737: Refactor buzz post components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.