OHRM5X-1733: Develop buzz - share photo component #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super-Chama
force-pushed
the
OHRM5X-1733
branch
from
5f2c3f7
to
a993807
Compare
RajithaKumara
approved these changes
Oct 27, 2022
| photos() { | ||
| return (this.media || []).map(photo => { | ||
| const {type, base64} = photo; | ||
| return `data:${type};base64,${base64}`; |
There was a problem hiding this comment.
can this component reuse, if we provide img src as URLs?
There was a problem hiding this comment.
yeah. planning to reuse.
Comment on lines
+87
to
+95
| const fileTypeValidator = validFileTypes([ | ||
| 'image/gif', | ||
| 'image/jpeg', | ||
| 'image/jpg', | ||
| 'image/pjpeg', | ||
| 'image/png', | ||
| 'image/x-png', | ||
| ]); | ||
| const fileSizeValidator = maxFileSize(1024 * 1024 * 2); |
There was a problem hiding this comment.
will get valid file types and size from BE via props. any possibility to hard code in controller for the moment
There was a problem hiding this comment.
I checked. Issue is this componet is deep inside. maybe we will have to use provide/inject
| name: 'PhotoUploadArea', | ||
|
|
||
| components: { | ||
| 'oxd-icon': Icon, |
There was a problem hiding this comment.
shall we register Icons as a global component, if it is highly used?
There was a problem hiding this comment.
I think we have globally registered oxd-icon-button component. this is used in few places, but at this stage no difference
Super-Chama
pushed a commit
to Super-Chama/orangehrm
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.