OHRM5X-1796: Create buzz - entities #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajithaKumara
force-pushed
the
OHRM5X-1796
branch
from
7a4d8f1
to
8424efd
Compare
SandeepaOHRM
reviewed
Nov 2, 2022
| /** | ||
| * @var int | ||
| * | ||
| * @ORM\Column(name="number_of_likes", type="integer", nullable=true) |
There was a problem hiding this comment.
Just asking. If there is a default value for this field as 0, is there any point of making it nullable?
There was a problem hiding this comment.
nice catch. about to define it in next PR. for the moment thought to keep it
| /** | ||
| * @var DateTime | ||
| * | ||
| * @ORM\Column(name="comment_time", type="datetime") |
There was a problem hiding this comment.
Seems text is required. If so, do we need to make this field nullable?
There was a problem hiding this comment.
no need to keep it nullable. I have revert it to make backward compatible with 4.x
ManulMax
reviewed
Nov 3, 2022
| * @group Buzz | ||
| * @group Entity | ||
| */ | ||
| class BuzzPostTest extends EntityTestCase |
There was a problem hiding this comment.
Will add test for other entities after merge
Super-Chama
pushed a commit
to Super-Chama/orangehrm
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Manul <manul@orangehrm.us.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.