respect environment variables same as AWS CLI. #19
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
respect AWS_REGION, AWS_DEFAULT_REGION, anr AWS_PROFILE. https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html#envvars-list
fujiwara
commented
Sep 27, 2023
cmd/root.go
Outdated
| if p, ok := os.LookupEnv("AWS_PROFILE"); ok { | ||
| return p | ||
| } | ||
| return "local" |
There was a problem hiding this comment.
local is the current default value, but the default value of AWS_PROFILE is default in AWS CLI.
There was a problem hiding this comment.
@fujiwara
Thank you for pointing that out.
The "local" value was something I had used during development and forgot to update. "default" would indeed be the correct value.
Could you please update the value from "local" to "default" and commit the changes again? I will merge your PR once that's done.
There was a problem hiding this comment.
@orangekame3 fixed! 1be1b8c
orangekame3
approved these changes
Sep 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Thank you for the great tool!
stree seems does not look AWS_REGON, AWS_DEFAULT_REGION, and AWS_PROFILE environment variables.
I use these variables normally when using CLI tools for AWS.
So I wrote a patch to set these variables as the default value of CLI parameters.
See also https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html#envvars-list