Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potentially fix windows x86 build #56

Merged
merged 5 commits into from
Jan 12, 2018
Merged

Conversation

krystophv
Copy link
Contributor

I believe this will fix the x86/x64 path issue on Windows, but I don't have an x86 machine to test against. Since you were able to detect that there was an issue with the build on an x86 machine, I'm guessing that perhaps you have one to test against?

Thanks for being so responsive with the other PR.

@oransel
Copy link
Owner

oransel commented Jan 9, 2018

Thank you for submitting the patch. MSBuild reference is correct now.

However, there are new issues for x86. The .NET Framework 4.0 reference is not correct. If you copy what ever 4.x framework version in C:\Program Files\Reference Assemblies\Microsoft\Framework\.NETFramework\ to 4.0, it passes the compilation process but linker reports unresolved external symbols for the TA functions, of which may be caused by the MSB8012 warnings given during specific library compilation processes.

@krystophv
Copy link
Contributor Author

Ok, I think I had to just pass the correct platform to the MSBuild command. Sorry to have you keep trying to no avail, but perhaps this change fixes it?

@oransel
Copy link
Owner

oransel commented Jan 10, 2018

Here is the output.txt

@krystophv
Copy link
Contributor Author

Thanks @oransel - it looks like you (and most users) will have a more up to date version of the .NETFramework available. The code will now attempt to locate the latest version and use it for the build instead of the original v4.0

@oransel oransel merged commit a146468 into oransel:master Jan 12, 2018
@oransel
Copy link
Owner

oransel commented Jan 12, 2018

@krystophv thank you very much for all your help. I pushed minor fixes for x86 to the master. Can you test on x64?

@krystophv
Copy link
Contributor Author

LGTM! Compiles with no errors on my x64 system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants