Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: package publishing building blocks #34

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

sajayantony
Copy link
Contributor

@sajayantony sajayantony commented Dec 12, 2023

This is a draft PR to enable publishing a nuget package once we agree on the home for the package. If we are publishing to nuget we should potentially create an organization and setup a github workflow to publish the packages on tag push.

This PR Involves the following changes.

  1. Move source to ./src and test to ./test . e.g. Pattern from https://github.com/dotnet/aspnetcore/tree/main/src/Components/Authorization
  2. Added make file to create a dotnet nupkg.
  3. Nugkg version determined based on git tag otherwise use a default dev tag 0.0.0-dev

Need to merge PR #33 before merging this as there are file moves involved here.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shizhMSFT shizhMSFT changed the title Package publishing building blocks chore: package publishing building blocks Dec 19, 2023
@shizhMSFT shizhMSFT changed the title chore: package publishing building blocks refactor: package publishing building blocks Dec 20, 2023
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
@sajayantony
Copy link
Contributor Author

@Wwwsylvia - updated with the new structure and tested the
make build pack
Generates the package with git tag given by git describe --tags

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 47b5c41 into oras-project:main Dec 21, 2023
1 check passed
@shizhMSFT shizhMSFT linked an issue Dec 26, 2023 that may be closed by this pull request
@shizhMSFT shizhMSFT mentioned this pull request Jan 15, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-arrange repository structure
2 participants