New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge `oras-credentials-go` back #584

Closed

Wwwsylvia opened this issue Sep 4, 2023 · 0 comments · Fixed by #589

Assignees

Labels

Milestone

Member

Wwwsylvia commented Sep 4, 2023

As oras-credentials-go has now reached a fairly stable state, we can proceed with merging it back into oras-go. This will allows us:

Reduce maintenance cost
Include credentials package in oras-go as an incremental feature with no dependency penalty
Increase visibility of oras-credentials-go as a package in oras-go

See oras-project/oras-credentials-go#80 for more details.

The text was updated successfully, but these errors were encountered:

Wwwsylvia added the enhancement label

Wwwsylvia added this to the v2.4.0 milestone

yizha1 assigned Wwwsylvia

Wwwsylvia mentioned this issue

feat: merge package credentials back from oras-credentials-go #589

Merged

Wwwsylvia closed this as completed in #589

Wwwsylvia added a commit that referenced this issue


          feat: merge package credentials back from oras-credentials-go (#589)

c130949

1. Add package `credentials` (migrated from
[`oras-credentials-go`](https://github.com/oras-project/oras-credentials-go))
and its corresponding description
2. Add new type `auth.CredentialFunc`
3. Migrate the credentials example from
[oras.land](https://oras.land/docs/client_libraries/go/#pull-an-image-using-the-docker-credential-store)
4. Change `auth.DefaultCache` to `auth.NewCache()` in examples

Resolves: #584
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment