Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise scope hints for push #100

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Revise scope hints for push #100

merged 2 commits into from
Jan 21, 2022

Conversation

shizhMSFT
Copy link
Contributor

Fix #99

Wwwsylvia
Wwwsylvia approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
revise scope hints for push
0ad251d 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
document the change
fa53e38 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT shizhMSFT merged commit 97cf20b into oras-project:main Jan 21, 2022
@shizhMSFT shizhMSFT deleted the fix_scope_hint branch January 21, 2022 05:43
@shizhMSFT shizhMSFT mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajayantony sajayantony sajayantony approved these changes

@northtyphoon northtyphoon northtyphoon approved these changes

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@deitch deitch Awaiting requested review from deitch

@jdolitsky jdolitsky Awaiting requested review from jdolitsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatch registry scope hint
4 participants
@shizhMSFT @sajayantony @northtyphoon @Wwwsylvia