Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile and scripts #104

Merged
merged 6 commits into from
Jan 21, 2022
Merged

Update Makefile and scripts #104

merged 6 commits into from
Jan 21, 2022

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Jan 21, 2022 •
edited

Resolves #61.

  • Update and clean up Makefile.
  • Fix test script.
  • Detect examples instead of hard coding.
  • Update go version to 1.17.6 for testing.

@shizhMSFT
update makefile
b6a1a29 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
update test script
b1893e4 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
update acceptance script
32ebe14 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
update golang version for tests
6e8f0d3 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
deitch
deitch reviewed Jan 21, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
scripts/acceptance.sh Outdated Show resolved Hide resolved
@shizhMSFT
better var reference
7ca141e 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
exclude vendor in find
be07485 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
deitch
deitch approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever you are ready, merge it in.

@shizhMSFT shizhMSFT merged commit 6dfff48 into oras-project:main Jan 21, 2022
@shizhMSFT shizhMSFT deleted the update_script branch January 21, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch deitch approved these changes

@jdolitsky jdolitsky Awaiting requested review from jdolitsky

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@Wwwsylvia Wwwsylvia Awaiting requested review from Wwwsylvia Wwwsylvia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Makefile and scripts
2 participants
@shizhMSFT @deitch