Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Target #118

Merged
merged 7 commits into from
Apr 11, 2022
Merged

File Target #118

merged 7 commits into from
Apr 11, 2022

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Mar 18, 2022 •
edited

Closes #56

Signed-off-by: Sylvia Lei lixlei@microsoft.com

shizhMSFT
shizhMSFT reviewed Mar 21, 2022
View reviewed changes
errdef/errors.go Outdated Show resolved Hide resolved
content/file/errors.go Show resolved Hide resolved
content/file/file.go Outdated Show resolved Hide resolved
content/file/file.go Show resolved Hide resolved
content/file/file.go Outdated Show resolved Hide resolved
content/file/file.go Outdated Show resolved Hide resolved
content/file/file.go Outdated Show resolved Hide resolved
content/file/file.go Show resolved Hide resolved
content/file/file.go Outdated Show resolved Hide resolved
content/file/file.go Outdated Show resolved Hide resolved
@Wwwsylvia Wwwsylvia changed the title File target File Target Mar 22, 2022
shizhMSFT
shizhMSFT approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions.

content/file/file.go Outdated Show resolved Hide resolved
content/file/file.go Outdated Show resolved Hide resolved
Wwwsylvia and others added 7 commits April 11, 2022 10:40
@Wwwsylvia
File target
08df062 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia
fix
541aaac 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia
minor refactor
ef6d5dd 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia
improve doc
61b0deb 
Signed-off-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com>
@Wwwsylvia
check closed
9d83fcd 
Signed-off-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com>
@Wwwsylvia
refactor
7ae443d 
Signed-off-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com>
@Wwwsylvia
fix closed
bdfecea 
Signed-off-by: Sylvia Lei <lixia_lei@outlook.com>
@shizhMSFT shizhMSFT merged commit db4a48e into oras-project:main Apr 11, 2022
@Wwwsylvia Wwwsylvia deleted the file_target branch April 11, 2022 02:45
@shizhMSFT shizhMSFT mentioned this pull request Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@deitch deitch Awaiting requested review from deitch

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Target
3 participants
@Wwwsylvia @jdolitsky @shizhMSFT