Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure OCI root directory #125

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Ensure OCI root directory #125

merged 1 commit into from
Mar 29, 2022

Conversation

Wwwsylvia
Copy link
Member

Fixes #123

Also replaced os.MkdirTemp with t.TempDir()

Signed-off-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

@akashsinghal Could you validate if this PR fixes the issue in ratify-project/ratify#148?

@akashsinghal
Copy link

Looks good @Wwwsylvia! This fixes the root directory issue.

@shizhMSFT shizhMSFT merged commit dd7d79f into oras-project:main Mar 29, 2022
qweeah pushed a commit to qweeah/oras-go that referenced this pull request Mar 30, 2022
Signed-off-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah pushed a commit to qweeah/oras-go that referenced this pull request Apr 6, 2022
Signed-off-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@Wwwsylvia Wwwsylvia deleted the oci_fix branch September 19, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: oci.New() returns error when root directory does not exist
3 participants