Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: update docker and docker/cli #428

Merged
merged 1 commit into from
Feb 15, 2023
Merged

bump: update docker and docker/cli #428

merged 1 commit into from
Feb 15, 2023

Conversation

benschlueter
Copy link

@benschlueter benschlueter commented Feb 3, 2023

since there is a small api change, one has to do the update manually

@shizhMSFT shizhMSFT added the v1 Things belongs to version 1.x label Feb 11, 2023
@shizhMSFT
Copy link
Contributor

@benschlueter Thanks for contributing. I am wondering if this change will cause an issue similar to #242

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to mention this version bump up in the release note as concerned by #242. /cc @Wwwsylvia

Signed-off-by: Benedict Schlueter <benedict.schlueter@inf.ethz.ch>
@shizhMSFT shizhMSFT changed the title update docker and docker/cli bump: update docker and docker/cli Feb 15, 2023
@shizhMSFT shizhMSFT merged commit b35b7cb into oras-project:v1 Feb 15, 2023
@benschlueter benschlueter deleted the update/docker branch February 15, 2023 12:31
@benschlueter
Copy link
Author

Sorry, overlooked the initial mention.
Yes, probably. I just go the issue from my go.mod file, since helm imported this lib and when dependable-bot upgraded my package it caused the incompatibility with this lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 Things belongs to version 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants