fix(oci): create blobs dir and define blobs dir name constant #520
Conversation
sparr
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
sparr
force-pushed
the
blobs_dir
branch
2 times, most recently
from
0cb6087
to
279d7be
Compare
|
Thank you both. @TerryHowe, can you approve running the check workflows? |
|
Created opencontainers/image-spec#1071 which would make the new constant here unnecessary. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #520 +/- ##
=======================================
Coverage 73.22% 73.22%
=======================================
Files 49 49
Lines 4602 4602
=======================================
Hits 3370 3370
Misses 923 923
Partials 309 309
|
|
opencontainers/image-spec#1071 is merged. If they have a release before this PR is merged, I'll switch over to using the blobs constant from there, ditto for ociImageIndexFile |
Cool. Let's wait for |
shizhMSFT
changed the title
shizhMSFT
changed the title
|
Sadly I missed the cutoff for rc4 by just a few hours. For unrelated reasons I've been talking to the maintainers over there about their releases, and it's unclear whether rc5 is days or months away, but weeks seems most likely. |
Signed-off-by: Clarence "Sparr" Risher <clrnc@amazon.com>
…roject#520) https://github.com/opencontainers/image-spec/blob/v1.0/image-layout.md#content specifies that the blobs dir must exist, so the changed ensureDir in this PR is a bugfix. The addition and use of the ociBlobsDir constant is more of a cleanup suggestion, and I can remove it if necessary. I've also asked for it to be added upstream at opencontainers/image-spec#1069 but that will probably take significantly longer. Signed-off-by: Clarence "Sparr" Risher <clrnc@amazon.com>
https://github.com/opencontainers/image-spec/blob/v1.0/image-layout.md#content specifies that the blobs dir must exist, so the changed ensureDir in this PR is a bugfix. The addition and use of the ociBlobsDir constant is more of a cleanup suggestion, and I can remove it if necessary. I've also asked for it to be added upstream at opencontainers/image-spec#1069 but that will probably take significantly longer. Signed-off-by: Clarence "Sparr" Risher <clrnc@amazon.com>
https://github.com/opencontainers/image-spec/blob/v1.0/image-layout.md#content specifies that the blobs dir must exist, so the changed ensureDir in this PR is a bugfix.
The addition and use of the ociBlobsDir constant is more of a cleanup suggestion, and I can remove it if necessary. I've also asked for it to be added upstream at opencontainers/image-spec#1069 but that will probably take significantly longer.