Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the implementation of pushing manifest for distribution-spec v1.1.0-rc3 #557

Merged
merged 10 commits into from
Jul 26, 2023

Conversation

Wwwsylvia
Copy link
Member

  1. Support pushing image index with a subject
  2. Check the "OCI-Subject" header

Resolves: #534

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #557 (3285991) into main (2c23ef6) will decrease coverage by 0.06%.
The diff coverage is 88.88%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   73.88%   73.83%   -0.06%     
==========================================
  Files          50       50              
  Lines        4706     4731      +25     
==========================================
+ Hits         3477     3493      +16     
- Misses        902      909       +7     
- Partials      327      329       +2     
Files Changed Coverage Δ
registry/remote/repository.go 70.21% <88.88%> (-0.16%) ⬇️

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 79d7081 into oras-project:main Jul 26, 2023
7 checks passed
@Wwwsylvia Wwwsylvia deleted the push_rc3 branch July 26, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the implementation of pushing manifest
3 participants