Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the implementation of deleting manifest for distribution-spec v1.1.0-rc3 #558

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

Wwwsylvia
Copy link
Member

Support deleting image indexes with a subject

Resolves: #535

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #558 (50b34e6) into main (79d7081) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   74.12%   73.98%   -0.15%     
==========================================
  Files          50       50              
  Lines        4731     4732       +1     
==========================================
- Hits         3507     3501       -6     
- Misses        898      904       +6     
- Partials      326      327       +1     
Files Changed Coverage Δ
registry/remote/repository.go 70.90% <100.00%> (+0.31%) ⬆️

... and 1 file with indirect coverage changes

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 6ec43e7 into oras-project:main Jul 27, 2023
7 checks passed
@Wwwsylvia Wwwsylvia deleted the delete_rc3 branch July 27, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the implementation of deleting manifest
3 participants