Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pack should not set artifactType when config is specified #565

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

Wwwsylvia
Copy link
Member

Related issue: #532
Related discussion: oras-project/oras#1011 (comment)

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #565 (eaa9238) into main (933ae41) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   74.09%   74.08%   -0.02%     
==========================================
  Files          51       51              
  Lines        4775     4773       -2     
==========================================
- Hits         3538     3536       -2     
  Misses        908      908              
  Partials      329      329              
Files Changed Coverage Δ
pack.go 81.20% <100.00%> (-0.25%) ⬇️

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit bbe92af into oras-project:main Aug 7, 2023
7 checks passed
@Wwwsylvia Wwwsylvia deleted the fix_pack branch August 7, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants